Update Images in integration tests#694
Conversation
yec-akamai
added
the
hotfix
yec-akamai
requested review from
mawilk90 and
mgwoj
and removed request for
a team
| except ApiError as e: | ||
| assert "Not found" in str(e.json) | ||
| assert e.status == 404 | ||
| assert 400 <= e.status < 500 |
There was a problem hiding this comment.
I spotted that API returns [403] Unauthorized for disk_id = 111111 or 111112 or 111122 etc., but not for 122222 or 123456 (then the error is [404] Not Found). IMO, it's a bit strange and inconsistent. Does it make sense to use e.g. disk_id = 123456 to get [404] Not Found as before and instead of possible range of error codes (400 <= e.status < 500) and clarify this behaviour with API Team?
There was a problem hiding this comment.
Interesting, not sure why API returns inconsistent error message. I did the error code range check just to make sure it's a client error, so it can tolerates the small backend divergence like this.
There was a problem hiding this comment.
I will ask API Team about that on Monday
There was a problem hiding this comment.
Ok, there will be a bug ticket created for this by API Team
| "g6-nanode-1", | ||
| target_region, | ||
| image="linode/ubuntu24.10", | ||
| image="linode/ubuntu24.04", |
5 participants
📝 Description
Fixing integration test issues seeing in workflow: https://github.com/linode/linode_api4-python/actions/runs/25501433562/job/74835124597?pr=691
Update to use LTS images in test cases instead of invalid ones. Change the error code assertion to match the API change.
✔️ How to Test